Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZIP-155: Parse addrv2 in Zebra #2681

Closed
teor2345 opened this issue Aug 26, 2021 · 1 comment · Fixed by #3022
Closed

ZIP-155: Parse addrv2 in Zebra #2681

teor2345 opened this issue Aug 26, 2021 · 1 comment · Fixed by #3022
Assignees
@teor2345
Labels
A-network Area: Network protocol updates or fixes C-enhancement Category: This is an improvement NU-5 Network Upgrade: NU5 specific tasks
Milestone
2021 Sprint 22

Comments

@teor2345
Copy link
Contributor

teor2345 commented Aug 26, 2021 •
edited
Loading

Motivation

ZIP-155 will require support for parsing inbound addrv2 messages.
But nodes can still keep sending addr messages.

We'll need to implement addrv2 parsing in both Zebra (in Rust) and the DNS Seeders (in Go).

This is the ticket for Zebra.

Scope

Zebra only needs to parse IPv4 and IPv6 in addrv2.

Parsing other address types is out of scope - they can be ignored.
Sending addrv2 is out of scope.

Deadline

ZIP-155 activates as of the NU5 mainnet activation network protocol version.
(On both mainnet and testnet.)
@teor2345 teor2345 added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage NU-5 Network Upgrade: NU5 specific tasks P-Medium A-network Area: Network protocol updates or fixes labels Aug 26, 2021
@teor2345 teor2345 added this to the 2021 Sprint 21 milestone Aug 26, 2021
@teor2345 teor2345 mentioned this issue Oct 13, 2021
Closed
@mpguerra
Copy link
Contributor

Hey team! Please add your planning poker estimate with ZenHub @conradoplg @dconnolly @jvff @oxarbitrage @teor2345 @upbqdn

@teor2345 teor2345 changed the title ZIP-155: Parse addrv2 in Zebra and the DNS seeders ZIP-155: Parse addrv2 in Zebra Oct 14, 2021
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Oct 29, 2021
This was referenced Nov 3, 2021
Merged
Merged
Merged
Merged
Merged
@teor2345 teor2345 linked a pull request Nov 5, 2021 that will close this issue
Parse received addrv2 messages #3022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teor2345 teor2345

Labels
A-network Area: Network protocol updates or fixes C-enhancement Category: This is an improvement NU-5 Network Upgrade: NU5 specific tasks
Projects
None yet
Milestone
2021 Sprint 22
Development

Successfully merging a pull request may close this issue.

Parse received addrv2 messages ZcashFoundation/zebra
2 participants
@mpguerra @teor2345