bug: getpeerinfo RPC should show inbound connections as well as outbound
#7893
Labels
A-rpc
Area: Remote Procedure Call interfaces
C-bug
Category: This is a bug
I-invalid-data
Zebra relies on invalid or untrusted data, or sends invalid data
S-needs-triage
Status: A bug report needs triage
Comments
teor2345
added
C-bug
teor2345
changed the title
getpeerinfo should show inbound connections as well as outboundgetpeerinfo RPC should show inbound connections as well as outbound
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Motivation
getpeerinfois documented to show inbound and outbound connections, but Zebra only shows outbound connections.Also, it shows current and recent outbound connections, but it should only show current connections.
Specifications
https://zcash.github.io/rpc/getpeerinfo.html
Complex Code or Requirements
We can add a network request for a list of peers, and then use that data for the RPC.
We don't need the address book, maybe we could remove it.
This change might need to be based on PR #7859, because it makes significant changes to the peer set.
Testing
Connect to Zebra with an inbound connection and make sure it shows up. We can do this in a unit test, or manually.
Add the
inboundfield to the RPC so we're sure.Follow Up Tickets
AddressBooktoOutboundAddressBookThe text was updated successfully, but these errors were encountered: