Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a single ResizeObserver instance #24

Closed
ZeeCoder opened this issue Nov 19, 2019 · 5 comments
Closed

Use a single ResizeObserver instance #24

ZeeCoder opened this issue Nov 19, 2019 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed to-discuss

Comments

@ZeeCoder
Copy link
Owner

Seems like it's more performant and the recommended pattern:
WICG/resize-observer#59

@ZeeCoder ZeeCoder added the enhancement New feature or request label Nov 19, 2019
@alatielle
Copy link

Related – #26

@ZeeCoder
Copy link
Owner Author

I'm not convinced yet whether this is an optimisation that's actually worth it or not.
I've only seen a single benchmark that seem to indicate that it might be better to use a single RO for all hook instances,
but it wasn't convincing enough to warrant the associated work.

I'd need a way to test this somehow for myself for a large number of observed elements and measure CPU / memory usage maybe, to see if there's a difference between using one or many RO instances.

@ZeeCoder
Copy link
Owner Author

Or if there was a comprehensive test / article / benchmark that demonstrated that using a single RO instance is significantly better, then I would consider it.

@ZeeCoder
Copy link
Owner Author

I forgot about this one:
que-etc/resize-observer-polyfill#13 (comment)

Seems like there's something in there, but I'd still need a way to benchmark CPU + memory usage, so that I could compare a results of the current implementation to one that uses a single instance.

@ZeeCoder ZeeCoder added the help wanted Extra attention is needed label Nov 13, 2020
@ZeeCoder
Copy link
Owner Author

I'd really appreciate someone well-versed in benchmarking UI to help out.

Repository owner locked and limited conversation to collaborators Aug 15, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
enhancement New feature or request help wanted Extra attention is needed to-discuss
Projects
None yet
Development

No branches or pull requests

2 participants