Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

__NODE_H__ header guard can create conflict #84

Closed
ZigRazor opened this issue Oct 13, 2021 · 4 comments · Fixed by #117
Closed

__NODE_H__ header guard can create conflict #84

ZigRazor opened this issue Oct 13, 2021 · 4 comments · Fixed by #117
Assignees
@AlfredCP
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers hacktoberfest hacktoberfest issue Priority:High Priority Label for high priority issue

Comments

@ZigRazor
Copy link
Owner

you may want to put lib name into the guard (CXXGRAPH_NODE_H), or you'll conflict with all of these guys
@ZigRazor ZigRazor added bug Something isn't working enhancement New feature or request good first issue Good for newcomers Priority:High Priority Label for high priority issue hacktoberfest hacktoberfest issue labels Oct 13, 2021
@ZigRazor ZigRazor pinned this issue Oct 13, 2021
@AlfredCP
Copy link
Contributor

Hi ZigRazor, I would like to contribute in your project.
I am new on this contributing process so I would like to start with this easy one to get used to the procedure to fork -> clone -> commit -> push -> PR

@ZigRazor
Copy link
Owner Author

Welcome @AlfredCP
Ok, I assign it to you. You can start correct it!

@AlfredCP
Copy link
Contributor

Shall I modify only NODE header, as the ticket title/description says, or should we change them all (the ones that does not include the library name)?
Like READER_H, CONSTVALUE_H ...

@ZigRazor
Copy link
Owner Author

If you want, you can change all

@AlfredCP AlfredCP mentioned this issue Oct 17, 2021
Merged
@ZigRazor ZigRazor unpinned this issue Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlfredCP AlfredCP

Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers hacktoberfest hacktoberfest issue Priority:High Priority Label for high priority issue
Projects
None yet
Milestone
No milestone
2 participants
@ZigRazor @AlfredCP