Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up pre-commit and isort #1473

Closed
mondeja opened this issue Jan 20, 2021 · 0 comments · Fixed by #1479
Closed

Set up pre-commit and isort #1473

mondeja opened this issue Jan 20, 2021 · 0 comments · Fixed by #1479
Labels
project-admin Anything to do with the administration & organisation of moviepy. I.e. project "meta". tooling Apps, integrations, workflows, tools... relevant to the maintenance of this project/repo.

Comments

@mondeja
Copy link
Collaborator

mondeja commented Jan 20, 2021 •
edited
Loading

To avoid #1084 periodically (with what that means for GIT blames) and to simplify the development process, I would do:

  • Set up pre-commit (example config). The developer will only need to do pre-commit install after the installation and literally forget to run black, flake8 and isort anymore, since they will be executed before each commit.
  • Set up isort inside the configuration of pre-commit.
  • Run isort checking in CI.
  • Document this in CONTRIBUTING.
  • Remove "Linting and formatting" from README.
@mondeja mondeja added project-admin Anything to do with the administration & organisation of moviepy. I.e. project "meta". tooling Apps, integrations, workflows, tools... relevant to the maintenance of this project/repo. labels Jan 20, 2021
@mondeja mondeja mentioned this issue Jan 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
project-admin Anything to do with the administration & organisation of moviepy. I.e. project "meta". tooling Apps, integrations, workflows, tools... relevant to the maintenance of this project/repo.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Setup 'isort' and 'pre-commit' mondeja/moviepy
1 participant
@mondeja