Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

separate audio codec dictionary from video codec dictionary #466

Closed
ghost opened this issue Mar 6, 2017 · 1 comment
Closed

separate audio codec dictionary from video codec dictionary #466

ghost opened this issue Mar 6, 2017 · 1 comment
Labels
audio Related to AudioClip, or handling of audio in general. refactor Does not affect the end user at all i.e. making code easier to read or PEP8 compliant.

Comments

@ghost
Copy link

ghost commented Mar 6, 2017

Current we are using the same dictionary to store values for audio and video codec names. We need to refactor the code so that these use separate dictionaries.. See pull request (#345) for more details.
@keikoro keikoro added audio Related to AudioClip, or handling of audio in general. refactor Does not affect the end user at all i.e. making code easier to read or PEP8 compliant. labels Nov 25, 2017
@keikoro
Copy link
Collaborator

keikoro commented Jan 14, 2022

It appears the suggestion was implemented and merged -> closing.

@keikoro keikoro closed this as completed Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
audio Related to AudioClip, or handling of audio in general. refactor Does not affect the end user at all i.e. making code easier to read or PEP8 compliant.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@keikoro