Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config_defaults.py is a poor UX #793

Closed
mgaitan opened this issue May 7, 2018 · 2 comments · Fixed by #1109
Closed

config_defaults.py is a poor UX #793

mgaitan opened this issue May 7, 2018 · 2 comments · Fixed by #1109
Assignees
Labels
documentation Related to documentation in official project docs or individual docstrings.

Comments

@mgaitan
Copy link
Collaborator

mgaitan commented May 7, 2018

Currently, the README recommends to manually edit config_defaults.py to set a custom FFMPEG path as imageio's alternative (to be used under an offline enviroment, experimental version, etc.)
Altought
This manual intervention is very weird, not only because it's no so easy to know where is this module (for instance, check #789 or #320) but because a python package not necessarily keeps in its source format after be installed. But moreover, it ties the configuration to the code. Why?

Altought it's possible to use enviroment variables as an alternative, it's only mentioned in config_defaults.py's docstring,.

On #148 (comment) I proposed to use a user-level configuration file to override default (built-in) configuration. It could be a ini-style or json file

@Zulko
Copy link
Owner

Zulko commented May 13, 2018

Im just seing that now. I'm not sure why in #148 it is question of changing a file before installing, the original idea was to change the config from inside the code with something like:

from moviepy.config import change_settings
change_settings(FFMPEG_BINARY="path/to/ffmpeg/binary")

Looking back at the code it has been changed in a way that seems to also support a configuration file, see here. It looks like either my doing or @cclauss, I dont get the git blame, and I dont remember exactly. Should have commented it better at the time.

@keikoro keikoro added the documentation Related to documentation in official project docs or individual docstrings. label Dec 16, 2018
@keikoro
Copy link
Collaborator

keikoro commented Dec 16, 2018

Not sure what the status or next steps on this are, but I tagged it with documentation for now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation in official project docs or individual docstrings.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants