You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the README recommends to manually edit config_defaults.py to set a custom FFMPEG path as imageio's alternative (to be used under an offline enviroment, experimental version, etc.)
Altought
This manual intervention is very weird, not only because it's no so easy to know where is this module (for instance, check #789 or #320) but because a python package not necessarily keeps in its source format after be installed. But moreover, it ties the configuration to the code. Why?
Altought it's possible to use enviroment variables as an alternative, it's only mentioned in config_defaults.py's docstring,.
On #148 (comment) I proposed to use a user-level configuration file to override default (built-in) configuration. It could be a ini-style or json file
The text was updated successfully, but these errors were encountered:
Im just seing that now. I'm not sure why in #148 it is question of changing a file before installing, the original idea was to change the config from inside the code with something like:
from moviepy.config import change_settings
change_settings(FFMPEG_BINARY="path/to/ffmpeg/binary")
Looking back at the code it has been changed in a way that seems to also support a configuration file, see here. It looks like either my doing or @cclauss, I dont get the git blame, and I dont remember exactly. Should have commented it better at the time.
Currently, the README recommends to manually edit
config_defaults.py
to set a custom FFMPEG path as imageio's alternative (to be used under an offline enviroment, experimental version, etc.)Altought
This manual intervention is very weird, not only because it's no so easy to know where is this module (for instance, check #789 or #320) but because a python package not necessarily keeps in its source format after be installed. But moreover, it ties the configuration to the code. Why?
Altought it's possible to use enviroment variables as an alternative, it's only mentioned in
config_defaults.py
's docstring,.On #148 (comment) I proposed to use a user-level configuration file to override default (built-in) configuration. It could be a ini-style or json file
The text was updated successfully, but these errors were encountered: