From aac70259edb1bec4a430ece72cb5ddef09442ff0 Mon Sep 17 00:00:00 2001 From: Marc Gilleron Date: Thu, 13 Jun 2024 18:43:34 +0100 Subject: [PATCH] Fix missing configuration warning on VoxelModifierMesh --- doc/source/changelog.md | 4 +++- modifiers/godot/voxel_modifier_mesh_gd.cpp | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/doc/source/changelog.md b/doc/source/changelog.md index fd4df30de..65ff92daa 100644 --- a/doc/source/changelog.md +++ b/doc/source/changelog.md @@ -26,7 +26,9 @@ Primarily developped with Godot 4.3. - Fixed slow loading when the database path contains `res://` or `user://` - `VoxelInstancer`: Fixed instances with LOD > 0 were generated on `VoxelTerrain` even though LOD isn't supported (ending up in weird positions). No instances should generate. - `VoxelMeshSDF`: Fixed error in the editor when trying to visualize the last slice (which turns out to be off by 1) - - `VoxelModifierMesh`: Fixed setting `isolevel` had no effect + - `VoxelModifierMesh`: + - Fixed setting `isolevel` had no effect + - Fixed missing configuration warning when parenting under `VoxelTerrain` (only `VoxelLodTerrain` is supported) - Breaking changes - `VoxelVoxLoader`: methods are now static, so no instance of the class need to be created diff --git a/modifiers/godot/voxel_modifier_mesh_gd.cpp b/modifiers/godot/voxel_modifier_mesh_gd.cpp index b4d0badac..c85f2b541 100644 --- a/modifiers/godot/voxel_modifier_mesh_gd.cpp +++ b/modifiers/godot/voxel_modifier_mesh_gd.cpp @@ -78,6 +78,8 @@ void VoxelModifierMesh::_on_mesh_sdf_baked() { #ifdef TOOLS_ENABLED void VoxelModifierMesh::get_configuration_warnings(PackedStringArray &warnings) const { + VoxelModifier::get_configuration_warnings(warnings); + if (_mesh_sdf.is_null()) { warnings.append(ZN_TTR("A {0} resource is required for {1} to function.") .format(varray(VoxelMeshSDF::get_class_static(), VoxelModifierMesh::get_class_static()))