Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatible with v8 of @sentry/node #68

Open
mydea opened this issue May 23, 2024 · 5 comments
Open

Make compatible with v8 of @sentry/node #68

mydea opened this issue May 23, 2024 · 5 comments

Comments

@mydea
Copy link

mydea commented May 23, 2024

This currently depends on v6 or v7 of the Sentry SDK, meaning it is not compatible with v8 as of now.

@Lms24
Copy link

Lms24 commented May 23, 2024

Adding to this, have you tried making a pino integration for Sentry rather than initializing the SDK a second time? Users will highly likely already have a Sentry setup, so plugging into this setup rather than initializing the SDK should work better.

We generally recommend this pattern for Sentry add on library creators. The docs still need an update to v8 but we're working on this at the moment.

@sergio-milu
Copy link

Having this same issue right now with Sentry v8 and pino-sentry

@glensc
Copy link
Collaborator

glensc commented May 23, 2024

@glensc
Copy link
Collaborator

glensc commented May 23, 2024

what are the changes? send a pr?

@glensc
Copy link
Collaborator

glensc commented Oct 14, 2024

also, the global install mode would get broken if using peer dependencies:

suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants