Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to change default comment color by theme? #506

Open
mtrazr opened this issue Oct 25, 2023 · 2 comments
Open

Is it possible to change default comment color by theme? #506

mtrazr opened this issue Oct 25, 2023 · 2 comments

Comments

@mtrazr
Copy link

mtrazr commented Oct 25, 2023

I switch light/dark themes based on the time of day. While most light themes have a reasonable comment color as well as a reasonable selected comment color, I haven't found a dark theme where I can read them.

I was wondering if Better comments lets me change the default comment color by theme so I can actually read them.

Thanks for a great extension.

@MattiasMartens
Copy link

MattiasMartens commented Nov 30, 2023

I came here to ask about this.

Some background for a potential feature request: VSCode appears to lack an API for determining whether a given theme is "light", "dark", or "high contrast". However most themes that clearly belong to one of these classifications also have the classification right there in the name, enabling workarounds that use "workbench.colorCustomizations" like this:

"workbench.colorCustomizations": {
    // Default
    "editor.background": "#000000",
    // Exception for light themes
    "[*Light*][AnotherTheme]": {
        "editor.background": "#ffffff"
    }
}

(As described in this StackOverflow answer)

If the better-comments extension provided color settings that inter-operated with "workbench.colorCustomizations", that would give the user the tools to solve this problem.

Maybe if for "color" or "background" color it was permitted to provide, instead of a hexcode, the name of a workbench color to inherit from?

@edwinhuish
Copy link

Hi gays, I have a fork Better Comments Next and I just add a option to overwrite tags options for light/dark themes.

better-comments.tagsLight overwrite tags options for light theme.
better-comments.tagsDark overwrite tags options for dark theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants