Maintainers

[lonix1]

Hi @aaron-bond, I see you've not been active here for a very long time.

Could you perhaps add maintainers to your repo? There's not shortage of those who want to be involved given the number of open PRs.

Please don't let this extension become abandoned - it's truly useful and you did a great job!

[jwoodard80]

Looks like the project has been forked to this repo and appears active.

https://github.com/edwinhuish/better-comments-next

[lonix1]

That fork is not a drop-in replacement: it fundamentally changes how the comment detection works, and may "break" existing comments.

[aaron-bond]

For what it's worth, this is the main reason I stopped working on this project. I was getting conflicting requests for functionality which would alternately break existing implementations and eventually decided the extension works "enough". I fully support the Next project and what it's doing, for anyone who wants to move over to that.

[lonix1]

Thank you for all the years you've invested in this extension... with all it's quirks, it's still the best.

And please reconsider allowing people to help you in this repo. This is where the action is, and where all users get extension updates. And there's no problem of breakage as everything already works.

[aaron-bond]

TBH I'd have no issues with additional contributors if I'd put the effort into decent test coverage early on :D
At this point I'm afraid of breaking anything, so reluctant to allow changes. If I were to seek contributions, that would be the the thing which unlocks everything else.

[lonix1]

To be clear, I think Aaron is saying: "if you want to get involved, write tests".

(Please correct me if I misunderstood.)

[aaron-bond]

Nope that's exactly the case. I'll happily merge PRs proving out current functionality. Thanks for clarifying!

[jwoodard80]

My sincere apologies if I spoke out of turn. I meant no ill will to the project. I simply came looking and things appeared dead so I wanted to leave a note for others doing the same.

Please feel free to close my issues.

[lonix1]

No worries, and no one was insulted. I'm sure that alternative extension will be very useful to many people.

But to those with large codebases who want a drop-in replacement without behavioural changes, they'll probably want to wait for some action from this repo.

And the author is willing to add maintainers as long as they first help to increase code coverage; after that he's open to allowing changes. A sensible approach.

[jwoodard80]

@aaron-bond If I may, perhaps it is worth updating the readme letting people know where you are with things and the needs you have. At first glance, with multiple PR's waiting and no updates in a year, it simply just appears to have been abandoned. However, I might have overlooked something.

Thank you for all your time you have given to the project. :-)

[edwinhuish]

@aaron-bond Thank you for your project.

I forked this project because I was waiting for vue support in a long time #388 (comment)

I can make PR of all changes here, and be maintainer of this project if you want.

[aaron-bond]

@edwinhuish I'm really glad you did! Your project is cool and you've been supporting it well, I'm glad it gives people another option. In regards to merging some of those changes back to this one - if we can get to a place of good test coverage here then I'm sure we could figure out what changes make sense here :)

[edwinhuish]

I don't know how to write the test unit for the vscode decoration.

If someone could provide assistance, that would be greatly appreciated.