Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Today from default format and insert date instead #38

Open
aashutoshrathi opened this issue Oct 14, 2018 · 4 comments
Open

Remove Today from default format and insert date instead #38

aashutoshrathi opened this issue Oct 14, 2018 · 4 comments
Labels
enhancement New feature or request Hacktoberfest

Comments

@aashutoshrathi
Copy link
Owner

aashutoshrathi commented Oct 14, 2018

Default format of output in console contains Today which is now irrelevant as we provide date arguements

@aashutoshrathi aashutoshrathi added enhancement New feature or request Hacktoberfest labels Oct 14, 2018
@ammarmallik
Copy link
Contributor

@aashutoshranthi please provide some description. I wanna do this task.

@GenericStudent
Copy link

@ammarmallik, The printed output is hard coded to say things such as:
{} have made {} public contribution(s) today. line 141
{} have done {} other public activit(y/ies) today. line 157
{} have starred {} repo(s) today. line 176

The logic has been modified with the addition of --date parameter, so these print statements need to reflect the date value (args['date']) which should be passed into the function calls between lines 298 and 307.

Hopefully that clarifies it a little more

@ammarmallik
Copy link
Contributor

Yes, Thanks. I'll make a pull request with its fix.

@ammarmallik
Copy link
Contributor

I have completed the dev work. Please merge this pull request #31 before applying these changes. This is the pull request #44.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants