Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistency in config loading between Java and Go #203

Open
yolocs opened this issue Mar 24, 2022 · 4 comments
Open

Fix inconsistency in config loading between Java and Go #203

yolocs opened this issue Mar 24, 2022 · 4 comments
Assignees
Labels
bug Something isn't working p2

Comments

@yolocs
Copy link
Contributor

yolocs commented Mar 24, 2022

For a sample config

backend:
  remote:
    address: "" # empty

In Go, it will return an error saying address is required for a remote backend config.
In Java, it won't return an error; instead, it will treat that as a remote backend is not needed (enabled).

@yolocs yolocs added the documentation Improvements or additions to documentation label Mar 24, 2022
@capri-xiyue
Copy link
Contributor

Do we need to fix such inconsistency?

@sethvargo
Copy link
Contributor

I agree with @capri-xiyue - can we fix these inconsistencies instead of just documenting them?

@yolocs
Copy link
Contributor Author

yolocs commented Jan 9, 2023

Yes, it would be preferable to completely fix the inconsistency. But there are 1) technical viability 2) language idiomaticity to consider. For this one, I agree we should just fix it. Renaming the title.

@yolocs yolocs changed the title Document nuances in config loading between Java and Go Fix inconsistency in config loading between Java and Go Jan 9, 2023
@capri-xiyue capri-xiyue added p2 bug Something isn't working and removed documentation Improvements or additions to documentation labels Jan 10, 2023
@sqin2019 sqin2019 self-assigned this Feb 8, 2023
@sqin2019
Copy link
Contributor

sqin2019 commented Feb 25, 2023

In addition to remote backend config, other inconsistencies:

  • cloudlogging set default logic
  • locallogging missing in go side, existing issue
  • go side missing LogType Unspecified
  • when security_context is not nil, go client require nonnil and nonempty security_context key where java only require nonnil security_context.
  • not sure if regex can be nil when filter related env vars are set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p2
Development

No branches or pull requests

4 participants