Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup injected error code used in integration test #358

Open
yolocs opened this issue Jan 7, 2023 · 0 comments
Open

Cleanup injected error code used in integration test #358

yolocs opened this issue Jan 7, 2023 · 0 comments
Labels
cleanup To keep the code clean and readable p2

Comments

@yolocs
Copy link
Contributor

yolocs commented Jan 7, 2023

In gRPC integration tests, we used some confusing error code for intentional failure cases, e.g. ResourceExhausted - made me feel we ran out of cloud quota. We should use a consistent error type to differentiate from real errors, e.g. PreconditionFailued
@yolocs yolocs added the cleanup To keep the code clean and readable label Jan 7, 2023
@capri-xiyue capri-xiyue added the p2 label Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup To keep the code clean and readable p2
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yolocs @capri-xiyue