New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Really unit test java grpc interceptor #361

Open

yolocs opened this issue Jan 7, 2023 · 0 comments

Labels

p2 test

Contributor

yolocs commented Jan 7, 2023

https://github.com/abcxyz/lumberjack/blob/main/clients/java-logger/library/src/test/java/com/abcxyz/lumberjack/auditlogclient/AuditLoggingServerInterceptorTests.java only tests some private functions. There is no coverage for how the interceptor really intercepts the gRPC calls.

We could reference some examples in https://github.com/grpc/grpc-java for how to better interceptors.

yolocs added the test label

yolocs mentioned this issue

Update Java deps #353

Merged

capri-xiyue added the p2 label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment