You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed (lines 97--117) in the install script https://github.com/abhijeetsingh1704/AcetoScan/blob/master/AcetoScan_Linux/install_linux.sh (see also the macosx version) that if run as root (or sudo), files are copied to /usr/local/bin, and if not run as root, a new folder is created in the user's home.
This not a typical, or even desirable property of an install script.
The crucial part of an installation is to make sure executables are placed in the PATH, or that the PATH includes the path to the executables. Which approach that is the best varies from project to project, and is often left to the user to decide (and the program provider to recommend, seldom force).
My suggestion is to perhaps skip the actual copying of files - definitely the creation of the /home/user/acetoscan folder - and just keep the dependency check. Then leave the copying to the user (as per recommendations).
However, this change requires that the code is written so not being dependent on the presence of ~/acetoscan/ (see other issues).
The text was updated successfully, but these errors were encountered:
I noticed (lines 97--117) in the install script
https://github.com/abhijeetsingh1704/AcetoScan/blob/master/AcetoScan_Linux/install_linux.sh
(see also the macosx version) that if run as root (or sudo), files are copied to/usr/local/bin
, and if not run as root, a new folder is created in the user's home.This not a typical, or even desirable property of an install script.
The crucial part of an installation is to make sure executables are placed in the PATH, or that the PATH includes the path to the executables. Which approach that is the best varies from project to project, and is often left to the user to decide (and the program provider to recommend, seldom force).
My suggestion is to perhaps skip the actual copying of files - definitely the creation of the
/home/user/acetoscan
folder - and just keep the dependency check. Then leave the copying to the user (as per recommendations).However, this change requires that the code is written so not being dependent on the presence of
~/acetoscan/
(see other issues).The text was updated successfully, but these errors were encountered: