Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid creating folders in the install scripts #98

Open
nylander opened this issue Jun 10, 2020 · 1 comment
Open

Avoid creating folders in the install scripts #98

nylander opened this issue Jun 10, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@nylander
Copy link
Collaborator

I noticed (lines 97--117) in the install script https://github.com/abhijeetsingh1704/AcetoScan/blob/master/AcetoScan_Linux/install_linux.sh (see also the macosx version) that if run as root (or sudo), files are copied to /usr/local/bin, and if not run as root, a new folder is created in the user's home.
This not a typical, or even desirable property of an install script.

The crucial part of an installation is to make sure executables are placed in the PATH, or that the PATH includes the path to the executables. Which approach that is the best varies from project to project, and is often left to the user to decide (and the program provider to recommend, seldom force).

My suggestion is to perhaps skip the actual copying of files - definitely the creation of the /home/user/acetoscan folder - and just keep the dependency check. Then leave the copying to the user (as per recommendations).

However, this change requires that the code is written so not being dependent on the presence of ~/acetoscan/ (see other issues).

@nylander
Copy link
Collaborator Author

See also #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants