From a8dd4cf78e2828671cfc77c09b239aa87573c6bd Mon Sep 17 00:00:00 2001
From: Steven Lindsay <steven.lindsay@ably.com>
Date: Thu, 24 Oct 2024 16:22:05 +0100
Subject: [PATCH] fixup! Allowing message action items to be already set.

---
 src/common/lib/types/message.ts | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/common/lib/types/message.ts b/src/common/lib/types/message.ts
index ee3324f1e..6911bca4e 100644
--- a/src/common/lib/types/message.ts
+++ b/src/common/lib/types/message.ts
@@ -19,18 +19,18 @@ const MessageActionArray: API.MessageAction[] = [
   'message_meta_occupancy',
 ];
 
+const MessageActionMap = new Map<API.MessageAction, number>(MessageActionArray.map((action, index) => [action, index]));
+
+const ReverseMessageActionMap = new Map<number, API.MessageAction>(
+  MessageActionArray.map((action, index) => [index, action]),
+);
+
 function toMessageActionString(actionNumber: number): API.MessageAction | undefined {
-  if (actionNumber in MessageActionArray) {
-    return MessageActionArray[actionNumber];
-  }
+  return ReverseMessageActionMap.get(actionNumber);
 }
 
 function toMessageActionNumber(messageAction?: API.MessageAction): number | undefined {
-  for (const [index, value] of MessageActionArray.entries()) {
-    if (value === messageAction) {
-      return index;
-    }
-  }
+  return messageAction ? MessageActionMap.get(messageAction) : undefined;
 }
 
 export type CipherOptions = {