Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ably.Realtime.Crypto.getDefaultParams() suddenly stopped working! #1000

Closed
alamaral opened this issue Jun 9, 2022 · 3 comments
Closed

Ably.Realtime.Crypto.getDefaultParams() suddenly stopped working! #1000

alamaral opened this issue Jun 9, 2022 · 3 comments

Comments

@alamaral
Copy link

alamaral commented Jun 9, 2022

We have code that has been deployed and working for a while that suddenly stopped working today with an exception:

This is the code:

     var hexString = "<a bunch of hex digits>";
     var cipherParams = Ably.Realtime.Crypto.getDefaultParams({ key:hexStringToArrayBuffer(hexString)});

This is the exception we're suddenly seeing:

TypeError: Cannot read properties of undefined (reading 'getDefaultParams')

I see a bunch of changes that happened today, but looking at the git diffs I don't see anything that is specifically
related to Ably.Realtime.Crypto:

commit 6c0a39c (HEAD -> main, tag: 1.2.23, origin/main, origin/HEAD)
Author: Owen Pearson owen.pearson@ably.com
Date: Thu Jun 9 17:36:06 2022 +0100
Revert dev changes to cdn_deploy script
commit 3ccd5a2
Author: Owen Pearson owen.pearson@ably.com
Date: Thu Jun 9 17:30:00 2022 +0100
Fix regex error in cdn_deploy script
commit 4a658c4
Merge: 3ce2b42 24df095
Author: Owen Pearson 48608556+owenpearson@users.noreply.github.com
Date: Thu Jun 9 17:11:50 2022 +0100
Merge pull request #999 from ably/release/1.2.23
Release 1.2.23
commit 24df095
Author: Owen Pearson owen.pearson@ably.com
Date: Thu Jun 9 16:56:11 2022 +0100
Bump version to 1.2.23
commit afd639f
Author: Owen Pearson owen.pearson@ably.com
Date: Thu Jun 9 16:53:54 2022 +0100
Update CHANGELOG
commit 3ce2b42
Merge: eeafdc7 c14ff50
Author: Owen Pearson 48608556+owenpearson@users.noreply.github.com
Date: Thu Jun 9 16:41:50 2022 +0100
Merge pull request #998 from ably/remove-sourcemaps
Revert CDN sourcemaps
commit eeafdc7
Merge: cd35d6b 8e9ffac
Author: Owen Pearson 48608556+owenpearson@users.noreply.github.com
Date: Thu Jun 9 16:41:41 2022 +0100
Merge pull request #993 from ably/salesforce-lightning-compat
Salesforce lightning compat
commit 8e9ffac
Author: Owen Pearson owen.pearson@ably.com
Date: Thu Jun 9 16:20:16 2022 +0100
Use optional chaining to check for console.log existence
commit c14ff50
Author: Owen Pearson owen.pearson@ably.com
Date: Thu Jun 9 15:30:19 2022 +0100
Revert sourcemap stuff
commit 38d76e7
Author: Owen Pearson owen.pearson@ably.com
Date: Thu Jun 9 14:13:19 2022 +0100
Remove sourcemaps from cdn_deploy script
commit 43f41bb
Author: Owen Pearson owen.pearson@ably.com
Date: Thu Jun 9 14:11:25 2022 +0100
Update cdn_deploy default includeDirs

┆Issue is synchronized with this Jira Uncategorised by Unito

@owenpearson
Copy link
Member

Hey @alamaral thanks for reporting this, this is a bug in the 1.2.23 release, I'm sorry for the inconvenience. We'll release a fix shortly, until then you should be able to use this method in v1.2.22. If you're using the CDN you can use this script tag to pin to the working version <script src="https://cdn.ably.com/lib/ably.min-1.2.22.js"></script>.

@owenpearson
Copy link
Member

@alamaral This is now fixed with version 1.2.24. It might take a little while for the CDN cache to refresh.

@alamaral
Copy link
Author

alamaral commented Jun 9, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants