Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect type for Message['connectionId'] #1301

Closed
JCB-K opened this issue May 25, 2023 · 2 comments · Fixed by #1305
Closed

Incorrect type for Message['connectionId'] #1301

JCB-K opened this issue May 25, 2023 · 2 comments · Fixed by #1305

Comments

@JCB-K
Copy link
Contributor

JCB-K commented May 25, 2023 •
edited
Loading

type according to typescript:
Screenshot 2023-05-25 at 15 51 30

Logging a message sent from the REST SDK:

Screenshot 2023-05-25 at 15 52 06

This means that connectionId should be typed as string | undefined
@sync-by-unito
Copy link

sync-by-unito bot commented May 25, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3612

@owenpearson owenpearson mentioned this issue May 26, 2023
Merged
@owenpearson
Copy link
Member

@JCB-K Thanks for reporting this, you're right that it should be optional - I've opened a PR to update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(typings): optional Message.connectionId ably/ably-js
2 participants
@JCB-K @owenpearson