Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XHR requests timing out leads to connection going into failed state #134

Closed
SimonWoolf opened this issue Sep 25, 2015 · 1 comment
Closed
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@SimonWoolf
Copy link
Member

An xhr request timing out (the sendTimeout) results in this chain of events:

Net effect: a single xhr request timing out results in the connection going into the 'failed' state (so it won't be retried), which is suboptimal.

None of the individual steps seem obviously wrong. My stab at the least correct step is the last one: I'm not sure a failed transport should necessarily imply a failed connection. PR based on that: #135

@SimonWoolf SimonWoolf added the bug Something isn't working. It's clear that this does need to be fixed. label Sep 25, 2015
@SimonWoolf
Copy link
Member Author

Fixed by #135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. It's clear that this does need to be fixed.
Development

No branches or pull requests

1 participant