-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internet Up URL & use of HTTPS #4
Comments
Your commit doesn't fix |
@kouno it's not necessary unless you are in a browser. |
So you're saying use HTTPS unconditionally? |
@mattheworiordan Not necessary but it's more secure. :) |
And slower. The request causes a delay before subsequent reconnect attempts are made and SSL handshakes typically add up to second to the request. Security in this case is not really relevant as far as I can see.. Regards, Sent from my phone
|
What!? Where did you get that fact? SSL handshakes are more expensive yes, but a full second is a lot of time. Cloudflare speaks about 1/3 of a second which is already more likely.
And it's only on slow certificate authority (aka Verisign) and I thought that Cloudflare was speeding up these things as much as possible. (https://blog.cloudflare.com/how-cloudflare-is-making-ssl-fast/)
Hu, sorry. I have no idea what you are speaking about :(. Maybe you could clarify that when I ask you on Monday. I do not think it's going to be critically slower TBH (as in, we absolutely need this to be super fast). Also this is only if we have a connection drop... And again, everywhere else we use SSL anyway, so I'm not sure why you would worry about this one in particular? And finally, it's hosted by Amazon on S3 so if that's slow, I don't know if I can believe in the internet anymore :). But honestly, the change itself is inconsequential. So you can safely ignore my comment. |
Damon you @kouno, OK, see ably/ably-ruby@12b8e8a. Happy? |
Yes. Damon me. ahahah 😄 |
@paddybyers, for the Java & Ably-js libraries, please can you use the correct URL for the Internet Up CDN test which is https://internet-up.ably-realtime.com/is-the-internet-up.txt, see this change in ably/ably-ruby@007e3b4.
Also, in the ably-js library, if the library is loaded over HTTPS and it then needs to do an internet up check it currently fails because it tries to do the request over HTTP, see
ably-js/browser/lib/transport/jsonptransport.js
Line 27 in add26a0
ably-js/browser/lib/transport/xhrtransport.js
Line 12 in 5bb90e8
@kouno this is the issue we saw FYI.
The text was updated successfully, but these errors were encountered: