Incorrect error shown in clients when account limits are hit

[mattheworiordan]

I am testing a local server and when I connect with the ably-js client library, the error shown is:

Ably: Rest(): started
Ably: Auth(): anonymous, using basic auth
Ably: Realtime.ConnectionManager(): started
Ably: Connection.connect():
Ably: ConnectionManager.requestState(): requested state: connecting
Ably: ConnectionManager.cancelTransitionTimer():
Ably: ConnectionManager.enactStateChange: setting new state: connecting; reason = undefined
Ably: ConnectionManager.connectImpl(): starting connection
Ably: ConnectionManager.startTransitionTimer(): transitionState: [object Object]
Ably: ConnectionManager.chooseTransport():
Ably: ConnectionManager.chooseTransport(): Transport recovery mode = clean
Ably: CometTransport.connect(): starting
Ably: CometTransport.connect(): uri: https://local-rest.ably.io:443/comet/connect
Ably: CometTransport.connect(): connectParams:?key=hG9k8g.5BC1rQ%3AyzNeBJDVGA1QuAKa
Ably: ConnectionManager.chooseTransport(): Unexpected error establishing transport; err = {"statusCode":404,"code":80000}
Ably: ConnectionManager.connectImpl(): Error: Unable to connect (no available host)
Ably: ConnectionManager.notifyState(): new state: disconnected
Ably: ConnectionManager.cancelTransitionTimer():
Ably: ConnectionManager.enactStateChange: setting new state: disconnected; reason = Unable to connect (no available host)

However, when I connect using a telnet session to see what is actually exchanged, I see the following:

$ telnet localhost 80
Connected to localhost.
Escape character is '^]'.
GET /?access_token=hG9k8g.C8WNMrAhOZ_1n7oNYqKvrzGbGnbySjpz5OPyWcwJHGTq_ZctT-dTNIItzuZ7WK88i7eOo4Yog2dG62-WqmGZ2uHFHOuLY9N0oGgLMOgYwT9c&format=json&echo=true HTTP/1.1
Connection: Upgrade
Upgrade: websocket
Host: localhost:80
Origin: localhost:80
Sec-WebSocket-Version: 13
Sec-WebSocket-Key: MTMtMTQzMzM0Nzg3NTU5OA==

HTTP/1.1 101 Switching Protocols
Upgrade: websocket
Connection: Upgrade
Sec-WebSocket-Accept: 0GFCTfIbbrcN75iYRZrkF7ykWMo=

{"action":9,"error":{"message":"account blocked (message limits exceeded)","code":40112,"statusCode":401}}

I suspect this is really an ably-js issue and not a realtime issue, but I wanted to raise it here first. We need to ensure clients are shown the correct error messages, especially for problems like this.

[paddybyers]

This issue is address with this fix: 72bb7d8

[SimonWoolf]

@me to add realtime test/limits

[SimonWoolf]

realtime test for emitting this error already exists: https://github.com/ably/realtime/blob/master/test/realtime/limits.js#L725-L795. (And per discussion yesterday: don't see how an ably-js test for this could work given afaik you can't specify an account limit for simulation apps -- unless we want to start having tests that mock out http responses..?).

[paddybyers]

Closing