Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ably-js does not call error callback when channel attach fails when using comet transport #81

Closed
SimonWoolf opened this issue Jul 31, 2015 · 2 comments
Labels
bug Something isn't working. It's clear that this does need to be fixed. failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug.

Comments

@SimonWoolf
Copy link
Member

With websocket transport, the attach callback is called with err = {"statusCode":400,"code":40010,"message":"Invalid channel id ()"}

With xhr, the callback is never called, though the error is logged to the console: "Ably: CometTransport.sendItems(): on complete: err = {"statusCode":400,"code":40010,"message":"Invalid channel id ()","serverId":"frontend.17d9.sandbox-eu-central-1-A.i-aaf1c864"}"

Example: channelattachempty test with transports: ['xhr']

@mattheworiordan
Copy link
Member

Rerun this test when new transport upgrade changes are deployed

@mattheworiordan mattheworiordan added bug Something isn't working. It's clear that this does need to be fixed. failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug. labels Aug 21, 2015
@SimonWoolf
Copy link
Member Author

Confirm fixed by upgrade changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. It's clear that this does need to be fixed. failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug.
Development

No branches or pull requests

2 participants