Identify that information are from scancode or another tool

[pombredanne]

For results such as packages, there is no direct way to determine from the JSON that this came from scancode or another tool. This is implicit. We should have a way to list which tool provided data explicitly.

[pombredanne]

A way to track which tools have touched a JSON could be to include some history/log so we know this has been touched by scancode, then aboutcode manager then something else, etc.

[patniharshit]

Hi, I am new here. Looking to contribute. Can you guide me on how to start with this issue?

[kartiksibal]

@pombredanne I'd like to resolve this, if no one is working on it.

If no one is. I was thinking of making a log file, wherein, whenever a tool makes changes to the JSON. There is an explicit record. Which can maybe be done, by creating a wrapper/decorator? I am not sure if I am expressing my thought correctly here. Please do share your approach.

Thanks :-)

[pombredanne]

@patniharshit @kartiksibal I guess only one of the two of you should work on this.

@patniharshit what's your approach? did you start? @kartiksibal same question.

@kartiksibal Your approach sounds ok. Show me some code so I can understand what you mean exactly.

[kartiksibal]

@pombredanne Sure. I'll do that.

[kartiksibal]

@pombredanne I am thinking of making a @log, decorator, for this, which we can maybe add to the main functions of our tools. Wherein, it will basically write to a file whenever a change to JSON has been made, containing the name of the tool used.

Am I somewhere near, to what your expectations are with this? :-)

[patniharshit]

@pombredanne I didn't had any ideas in particular. I was hoping to get started here if somebody could guide me on what to do.
But since kartiksibal has something, I am cool with he going ahead with this.

[kartiksibal]

@patniharshit I think, what matters is coming up with an efficient solution to the problem, it doesn't matter who does it. We are here to improvise the product and learn. :-D

I'd love to know how you were thinking of approaching this issue. :-)

[pombredanne]

@kartiksibal I can comment when I see some code.

[kartiksibal]

@pombredanne Sir, I have made a very minuscule change in /src/scancode/cli.py. Just when we dump the JSON data, I have added this . Is this somewhere on the lines of what you were expecting with this enhancement? :-)

[pombredanne]

@kartiksibal you wrote:

I have made a very minuscule change in /src/scancode/cli.py. Just when we dump the JSON data, I have added this . Is this somewhere on the lines of what you were expecting with this enhancement? :-)

It is hard for me to review paste bins: do you mind make a PR for your change or attach or submit a patch instead?

[kartiksibal]

@pombredanne Apologies for the delay, got too engrossed in the project and I messed up a little here. 😅

[pombredanne]

This is closed in favor of tracking this in #211