Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make distinction between patched and unaffected packages #144

Closed
sbs2001 opened this issue Jan 30, 2020 · 1 comment
Closed

Make distinction between patched and unaffected packages #144

sbs2001 opened this issue Jan 30, 2020 · 1 comment

Comments

@sbs2001
Copy link
Collaborator

sbs2001 commented Jan 30, 2020

We currently put packages into just two categories

  1. ImpactedPackage , these are affected by the particular vulnerability and are not secure to use.
    2.)ResolvedPackage , these are unaffected by the particular vulnerability , atleast they are supposed to be . This category includes a) packages which were affected by a vulnerability and then got fixed as well as b) packages which weren't affected when the vulnerability was discovered.

Do we need to make the distinction between (a) & (b) ? I believe we should after the following chat with @haikoschol gave the following reason

there could be a case where a user wants to know when a vulnerability was introduced. let's say there's a very complicated vulnerability and a "fix" is published but it is controversial whether this fixes the vulnerability properly or only one attack vector
otoh, if we make this distinction in our data model because the data sources we are looking at contain it, how do we handle data sources that don't contain this information?

@sbs2001
Copy link
Collaborator Author

sbs2001 commented Apr 26, 2021

Fixed via #436 . We keep track of vulnerable package and it's closest non-vulnerable package(version-wise), aka patched package.

@sbs2001 sbs2001 closed this as completed Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant