-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve naming and be consistent about it #447
Comments
Means wherever we encounter these safe_package, patched_package, resolved_package, we need to replace them. But by which common name, also will it not conflict other parts.? I am new pls guide me. |
@MUzairS15 re:
yes. The first step is to find the good names alright! We would need to survey the words used to depict affected/patched in other tools:
|
Ok. |
Scan the whole code make a list and choose one from there and apply changes right? |
yes, that would be a start: a survey of the terms used in the external data sources we use in the importers here and some research outside. And posting the results of this research here before we do anything else. |
Currently we use different terms to describe the same thing
eg safe_package, patched_package, resolved_package .
This should be avoided. We should stick to something once for all.
The https://github.com/nexB/vulnerablecode/blob/fd1572438831ff41cfc856da5d3194b5f2ef825b/vulnerabilities/helpers.py#L124 will also need a good name.
See the comments at #436 for more details
The text was updated successfully, but these errors were encountered: