From 4ec631b1af11f6dd130e4b4cbd7fbd5c74b904a4 Mon Sep 17 00:00:00 2001 From: Louis Matthijssen Date: Tue, 16 May 2023 14:52:32 +0200 Subject: [PATCH] Fix join warning using Ecto 3.10.0+ Since 3.10.0, Ecto warns when joining without `:on`: > missing `:on` in join, defaulting to `on: true`. --- lib/dataloader/ecto.ex | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/dataloader/ecto.ex b/lib/dataloader/ecto.ex index 1454b03..0db0570 100644 --- a/lib/dataloader/ecto.ex +++ b/lib/dataloader/ecto.ex @@ -365,7 +365,7 @@ if Code.ensure_loaded?(Ecto) do results = from(input in subquery(inputs_query), as: :input) - |> join(:inner_lateral, q in subquery(inner_query)) + |> join(:inner_lateral, [], q in subquery(inner_query), on: true) |> select([_input, q], q) |> repo.all(repo_opts) @@ -728,6 +728,7 @@ if Code.ensure_loaded?(Ecto) do from(x in schema, as: :parent, inner_lateral_join: y in subquery(inner_query), + on: true, where: field(x, ^pk) in ^Enum.map(structs, &Map.get(&1, pk)), select: {field(x, ^pk), y} )