Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider different auth scheme design #1571

Open
dborovcanin opened this issue Mar 4, 2022 · 0 comments
Open

Reconsider different auth scheme design #1571

dborovcanin opened this issue Mar 4, 2022 · 0 comments

Comments

@dborovcanin
Copy link
Collaborator

dborovcanin commented Mar 4, 2022

ENHANCEMENT

  1. Describe the enhancement you are requesting:
    I don't like having both token and key in the list request. I prefer that apiutil.ExtractAuthToken(r) can decide what's the auth scheme and that auth gRPC client knows how to authorize different tokens. This can be done by either separating APIs or updating auth gRPC. Anyways, this is not related to this PR, and we'll create a separate issue from this comment to address it later and not to block this PR.

Originally posted by @dusanb94 in https://github.com/mainflux/mainflux/pull/1568#r819431029

  1. Indicate the importance of this enhancement to you (must-have, should-have, nice-to-have).
    This is a mus-have enhancement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant