Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug log level to Mainflux logger #379

Closed
ghost opened this issue Aug 30, 2018 · 5 comments
Closed

Add debug log level to Mainflux logger #379

ghost opened this issue Aug 30, 2018 · 5 comments
Assignees
Milestone

Comments

@ghost
Copy link

ghost commented Aug 30, 2018

Currently, the Mainflux logger is missing the debug log level. There are many cases were this level can be used. Also, add SetLevel method to Mainflux logger. Every service should have this logging level parameter set as environment variable MF_<service_name>_LOG_LEVEL.

@ghost ghost added the feature label Aug 30, 2018
@anovakovic01 anovakovic01 self-assigned this Aug 30, 2018
@drasko drasko added this to the 0.6.0 milestone Sep 5, 2018
@mfinley3
Copy link
Contributor

mfinley3 commented Sep 20, 2018

Along with adding the debug level, I was wondering if it would be beneficial to also be able to select the log level? That way someone can select if they want mainflux to write out all of the infos or not.

Specifically something that would look like this:

| Variable             | Description                              | Default      |
|----------------------|------------------------------------------|--------------|
| MF_USERS_LOG_LEVEL   | Log level for Users (info, warn, error)  | info         | 

For my team and I, everything that goes into stdout gets pulled into the ELK stack for us. So it would be beneficial for us to reduce the number of success messages printed out in each component.

Let me know your thoughts on this. If it is something that sounds useful I can get a PR open asap, work has been done just have some hoops to jump through.

@anovakovic01
Copy link
Contributor

anovakovic01 commented Sep 20, 2018

This was the plan, just not written in issue description. I will update description.

@drasko
Copy link
Contributor

drasko commented Sep 20, 2018

@mfinley3 looks like we are aligned, will you be sending PR?

@mfinley3
Copy link
Contributor

mfinley3 commented Sep 20, 2018

Yep! I will get a PR opened here ASAP. I am working on our teams path to contributing back now!

I made a few small cleanup changes to the internal PR. Going to have someone look those over and should have an open PR here tomorrow morning!

@anovakovic01
Copy link
Contributor

Resolved by #402.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants