Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Produce warning if chart uses .Capabilities.APIVersions #6

Closed
abstrask opened this issue Oct 2, 2024 · 0 comments · Fixed by #9
Closed

Produce warning if chart uses .Capabilities.APIVersions #6

abstrask opened this issue Oct 2, 2024 · 0 comments · Fixed by #9

Comments

@abstrask
Copy link
Owner

abstrask commented Oct 2, 2024 •
edited
Loading

Produce warning if chart uses .Capabilities.APIVersions, which could affect rendered manifests, causing diff to not paint the full picture.

For example, Argo Workflows) won't render a ServiceMonitor resource, unless the API monitoring.coreos.com/v1 is being served.

This could be done by building on #4, that pulls and untars certain chart types. If to this for all charts (then template the local files), we can run grep to determine if a warning should be produced:

grep -R --include='*.yaml' --include='*.yml' --include='*.tpl' ".Capabilities.APIVersions"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Produce warning if chart uses .Capabilities.APIVersions abstrask/flux-helm-diff
1 participant
@abstrask