initial kubernetes support #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 3, 2020 06:18
- adds support for kubernetes violation detection in yaml using repo - adds default iac versions/types per policy/cloud provider - policies and more unit tests to follow in the next checkin
- add Jon’s change for a relative directory resolve bug - go.mod tidy - don’t call os.exit() from run() when running unit tests - simplify k8s normalization—no manual json parsing - fix default AWS IaC type (was set to was instead of terraform) - fixed JSON loading bug - increased unit test coverage
williepaul
requested review from
cesar-rodriguez,
kanchwala-yusuf and
acc-jon
added 2 commits
September 4, 2020 01:54
- silenced a noisy log and downgraded the severity of another
Codecov Report
@@ Coverage Diff @@
## master #313 +/- ##
==========================================
+ Coverage 59.36% 63.07% +3.70%
==========================================
Files 48 56 +8
Lines 982 1205 +223
==========================================
+ Hits 583 760 +177
- Misses 350 379 +29
- Partials 49 66 +17
|
cesar-rodriguez
previously requested changes
Sep 4, 2020
added 6 commits
September 8, 2020 17:43
- error message updates - added config-only unit test - removed unnecessary checks in the api server - changed resource representation to match terraforms resource naming
- error message updates - added config-only unit test - removed unnecessary checks in the api server - changed resource representation to match terraforms resource naming - fixed namespace name issue - added specific handling for daemonsets - updated version to 1.1.0
|
Kudos, SonarCloud Quality Gate passed!
|
kanchwala-yusuf
approved these changes
Sep 15, 2020
kanchwala-yusuf
dismissed
cesar-rodriguez’s stale review
Review has already been addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.