Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for booting terrascan demo #319

Merged
merged 5 commits into from
Sep 26, 2020

Conversation

kklin
Copy link
Contributor

@kklin kklin commented Sep 13, 2020

@cesar-rodriguez we've put together the first version of the GitHub badge!

Screen Shot 2020-09-13 at 3 27 00 PM

As far as I can tell, the booted version of Terrascan works. I was able to curl v1/terraform/v12/aws/local/file/scan.

What do you think?

@codecov
Copy link

codecov bot commented Sep 13, 2020

Codecov Report

Merging #319 into master will increase coverage by 2.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
+ Coverage   59.36%   61.45%   +2.09%     
==========================================
  Files          48       57       +9     
  Lines         982     1069      +87     
==========================================
+ Hits          583      657      +74     
+ Misses        350      346       -4     
- Partials       49       66      +17     
Impacted Files Coverage Δ
pkg/utils/path.go 89.18% <0.00%> (-10.82%) ⬇️
pkg/cli/init.go 20.00% <0.00%> (-8.58%) ⬇️
pkg/cli/server.go 20.00% <0.00%> (-8.58%) ⬇️
pkg/writer/json.go 20.00% <0.00%> (-8.58%) ⬇️
pkg/writer/yaml.go 20.00% <0.00%> (-8.58%) ⬇️
pkg/writer/xml.go 12.50% <0.00%> (-7.50%) ⬇️
pkg/iac-providers/terraform/v12/load-file.go 65.00% <0.00%> (-4.57%) ⬇️
pkg/policy/opa/engine.go 38.67% <0.00%> (-3.27%) ⬇️
pkg/iac-providers/terraform/v12/convert.go 72.44% <0.00%> (-3.09%) ⬇️
pkg/notifications/webhook/webhook.go 23.52% <0.00%> (-2.79%) ⬇️
... and 47 more

@cesar-rodriguez cesar-rodriguez self-assigned this Sep 17, 2020
README.md Show resolved Hide resolved
@kklin
Copy link
Contributor Author

kklin commented Sep 23, 2020

Hi @cesar-rodriguez, did you see the latest version of the docs?

@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@cesar-rodriguez cesar-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. Thanks!

@cesar-rodriguez cesar-rodriguez merged commit afc78b5 into tenable:master Sep 26, 2020
@kklin
Copy link
Contributor Author

kklin commented Sep 28, 2020

Thanks! Let me know if you have any issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants