hopefully remove test failures due to non-deterministic comparisons #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #420 +/- ##
=======================================
Coverage 66.21% 66.21%
=======================================
Files 85 85
Lines 1915 1915
=======================================
Hits 1268 1268
Misses 535 535
Partials 112 112 |
williepaul
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparing the JSON marshaled values of the AllResourceConfigs seemed to be sensitive to the order of elements in the array under each map key and led to intermittent test failures. This change performs that comparison with a map whose keys are based on the file and resource id, so that the order will be deterministic. I am not able to reproduce the test failures on my machine, so I can't be certain this will be sufficient--I only change the first-order map elements and we might need to drill deeper into the resource definitions.