-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecated gcs bucket #462
Deprecated gcs bucket #462
Conversation
I also included the updated files from |
Codecov Report
@@ Coverage Diff @@
## master #462 +/- ##
==========================================
+ Coverage 74.46% 74.69% +0.22%
==========================================
Files 87 88 +1
Lines 2005 2039 +34
==========================================
+ Hits 1493 1523 +30
- Misses 379 382 +3
- Partials 133 134 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jdyke,
Do we need to update our go mod files for this issue? If not required can we please revert back the changes?
reverting go updates
Hi @kanchwala-yusuf! Sorry about that - I have reverted those updates. Thanks! |
reverting go updates
Kudos, SonarCloud Quality Gate passed! |
Resolves #453
GCP deprecated the Google Cloud Storage (GCS) bucket configuration name of
bucket_policy_only
and replaced it withuniform_bucket_level_access
. This PR replaces the old configuration with the new.Thanks