Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated gcs bucket #462

Merged
merged 4 commits into from
Jan 8, 2021
Merged

Deprecated gcs bucket #462

merged 4 commits into from
Jan 8, 2021

Conversation

jdyke
Copy link
Contributor

@jdyke jdyke commented Jan 7, 2021

Resolves #453

GCP deprecated the Google Cloud Storage (GCS) bucket configuration name of bucket_policy_only and replaced it with uniform_bucket_level_access. This PR replaces the old configuration with the new.

Thanks

@jdyke
Copy link
Contributor Author

jdyke commented Jan 7, 2021

I also included the updated files from make cicd that I ran locally. Let me know if you want me to remove those from this PR.

@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #462 (f506ca4) into master (c39a76d) will increase coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #462      +/-   ##
==========================================
+ Coverage   74.46%   74.69%   +0.22%     
==========================================
  Files          87       88       +1     
  Lines        2005     2039      +34     
==========================================
+ Hits         1493     1523      +30     
- Misses        379      382       +3     
- Partials      133      134       +1     
Impacted Files Coverage Δ
pkg/policy/opa/engine.go 61.72% <0.00%> (-2.46%) ⬇️
pkg/utils/skip_rules.go 100.00% <0.00%> (ø)
pkg/iac-providers/terraform/v12/resource.go 66.66% <0.00%> (+1.66%) ⬆️
pkg/iac-providers/kubernetes/v1/normalize.go 87.50% <0.00%> (+13.03%) ⬆️

Copy link
Contributor

@kanchwala-yusuf kanchwala-yusuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jdyke,
Do we need to update our go mod files for this issue? If not required can we please revert back the changes?

reverting go updates
@jdyke
Copy link
Contributor Author

jdyke commented Jan 8, 2021

Hey @jdyke,
Do we need to update our go mod files for this issue? If not required can we please revert back the changes?

Hi @kanchwala-yusuf! Sorry about that - I have reverted those updates.

Thanks!

reverting go updates
@sonarcloud
Copy link

sonarcloud bot commented Jan 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kanchwala-yusuf kanchwala-yusuf merged commit f9b176c into tenable:master Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uniformBucketEnabled.rego referencing deprecated config
2 participants