Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: scan terraform registry modules as remote type #513

Merged
merged 5 commits into from
Feb 10, 2021

Conversation

patilpankaj212
Copy link
Contributor

  1. Added support for scanning terraform registry as remote type
  2. Refactored code and modified tests

User can now run below to scan terraform remote modules in terraform registry. eg:

terrascan scan -r terraform-registry -u terraform-aws-modules/eks/aws:13.2.1

@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #513 (50d64c3) into master (9088544) will increase coverage by 0.77%.
The diff coverage is 96.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #513      +/-   ##
==========================================
+ Coverage   75.57%   76.35%   +0.77%     
==========================================
  Files          94       94              
  Lines        2227     2258      +31     
==========================================
+ Hits         1683     1724      +41     
+ Misses        401      396       -5     
+ Partials      143      138       -5     
Impacted Files Coverage Δ
pkg/cli/register.go 5.55% <0.00%> (-0.70%) ⬇️
pkg/iac-providers/terraform/commons/load-dir.go 85.13% <96.00%> (+2.27%) ⬆️
pkg/cli/scan.go 77.77% <100.00%> (ø)
pkg/downloader/getter.go 86.36% <100.00%> (+3.67%) ⬆️
pkg/downloader/interface.go 100.00% <100.00%> (ø)
pkg/downloader/module-download.go 91.56% <100.00%> (ø)
pkg/downloader/remote-modules.go 100.00% <100.00%> (ø)

2. add wiki link for punycode
3. use filepath.Join()
@sonarcloud
Copy link

sonarcloud bot commented Feb 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@jlk jlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jlk jlk merged commit 26bae02 into tenable:master Feb 10, 2021
@patilpankaj212 patilpankaj212 deleted the remote-type-enhancements branch April 7, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants