Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix - k8s resources config data has absolute source paths for resources #644

Merged
merged 2 commits into from
Apr 8, 2021
Merged

fix - k8s resources config data has absolute source paths for resources #644

merged 2 commits into from
Apr 8, 2021

Conversation

patilpankaj212
Copy link
Contributor

  1. k8s iac - filename should be relative
  2. fix failing e2e tests

@patilpankaj212 patilpankaj212 linked an issue Apr 7, 2021 that may be closed by this pull request
terrascan using absolute path for "source" value of resource #642
Closed
@codecov
Copy link

codecov bot commented Apr 7, 2021 •
edited
Loading

Codecov Report

Merging #644 (a50f5c7) into master (41b159c) will decrease coverage by 0.06%.
The diff coverage is 60.00%.

❗ Current head a50f5c7 differs from pull request most recent head aed6d09. Consider uploading reports for the commit aed6d09 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #644      +/-   ##
==========================================
- Coverage   78.09%   78.02%   -0.07%     
==========================================
  Files         104      104              
  Lines        2597     2607      +10     
==========================================
+ Hits         2028     2034       +6     
- Misses        422      425       +3     
- Partials      147      148       +1
Impacted Files Coverage Δ
pkg/iac-providers/kubernetes/v1/load-dir.go 72.41% <60.00%> (-6.54%) ⬇️

kanchwala-yusuf
kanchwala-yusuf previously approved these changes Apr 7, 2021
View reviewed changes
jlk
jlk previously approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@jlk jlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally LGTM, maybe tweak name on method to make it more clear.

@patilpankaj212 patilpankaj212 requested a review from jlk April 7, 2021 15:21
@patilpankaj212 patilpankaj212 force-pushed the fix-k8s-source-path branch 2 times, most recently from a50f5c7 to aed6d09 Compare April 8, 2021 10:50
@sonarcloud
Copy link

sonarcloud bot commented Apr 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kanchwala-yusuf kanchwala-yusuf merged commit 23c8281 into tenable:master Apr 8, 2021
@patilpankaj212 patilpankaj212 deleted the fix-k8s-source-path branch May 5, 2022 11:36
@patilpankaj212 patilpankaj212 restored the fix-k8s-source-path branch May 5, 2022 11:36
@patilpankaj212 patilpankaj212 deleted the fix-k8s-source-path branch May 5, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanchwala-yusuf kanchwala-yusuf kanchwala-yusuf approved these changes

@jlk jlk Awaiting requested review from jlk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

terrascan using absolute path for "source" value of resource
3 participants
@patilpankaj212 @jlk @kanchwala-yusuf