Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding release checklist #734

Merged
merged 3 commits into from
May 6, 2021
Merged

Conversation

jlk
Copy link
Contributor

@jlk jlk commented May 5, 2021

Initial PR for a release checklist.

Creating PR now to get feedback - let me know any thoughts, or feel free to contribute.

I know this is missing integration testing - if somebody's bored, feel free to add, otherwise I'll get that in soon.

@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #734 (2161748) into master (d8fd9c4) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #734      +/-   ##
==========================================
- Coverage   73.28%   73.18%   -0.10%     
==========================================
  Files         110      110              
  Lines        3099     3170      +71     
==========================================
+ Hits         2271     2320      +49     
- Misses        650      668      +18     
- Partials      178      182       +4     
Impacted Files Coverage Δ
pkg/iac-providers/kubernetes/v1/load-dir.go 67.74% <0.00%> (-4.68%) ⬇️
pkg/cli/run.go 88.57% <0.00%> (-2.86%) ⬇️
pkg/iac-providers/helm/v3/load-dir.go 82.89% <0.00%> (-2.73%) ⬇️
pkg/iac-providers/terraform/commons/load-dir.go 80.59% <0.00%> (-2.48%) ⬇️
pkg/iac-providers/kustomize/v3/load-dir.go 71.69% <0.00%> (-2.31%) ⬇️
pkg/iac-providers/kubernetes/v1/normalize.go 88.05% <0.00%> (-2.31%) ⬇️
pkg/results/types.go 100.00% <0.00%> (ø)
pkg/k8s/admission-webhook/validating-webhook.go 62.00% <0.00%> (ø)
pkg/utils/resource.go
pkg/iac-providers/output/types.go 69.56% <0.00%> (ø)
... and 3 more

Copy link
Contributor

@devang-gaur devang-gaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes requested. thanks for the initiative.

release_checklist.md Outdated Show resolved Hide resolved
release_checklist.md Outdated Show resolved Hide resolved
jlk and others added 2 commits May 5, 2021 08:30
Co-authored-by: Devang Gaur <devang.gaur@accurics.com>
@sonarcloud
Copy link

sonarcloud bot commented May 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@devang-gaur devang-gaur merged commit 964167b into tenable:master May 6, 2021
@kanchwala-yusuf
Copy link
Contributor

Thank you @jlk for this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants