Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/k8s id field #873

Merged
merged 3 commits into from
Jun 17, 2021
Merged

Bugfix/k8s id field #873

merged 3 commits into from
Jun 17, 2021

Conversation

gaurav-gogia
Copy link
Contributor

  • remove unnecessary policies
  • add id fields where missing

@gaurav-gogia gaurav-gogia added the policy Issue concerning policy maintainers. label Jun 17, 2021
@gaurav-gogia gaurav-gogia self-assigned this Jun 17, 2021
@codecov
Copy link

codecov bot commented Jun 17, 2021 •
edited
Loading

Codecov Report

Merging #873 (fb31746) into master (7d20723) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #873   +/-   ##
=======================================
  Coverage   78.29%   78.29%           
=======================================
  Files         164      164           
  Lines        4359     4359           
=======================================
  Hits         3413     3413           
  Misses        730      730           
  Partials      216      216

@sonarcloud
Copy link

sonarcloud bot commented Jun 17, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

nasir-rabbani
nasir-rabbani reviewed Jun 17, 2021
View reviewed changes
Copy link
Contributor

@nasir-rabbani nasir-rabbani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation tests passed for these file changes, looks good to me.

@gaurav-gogia gaurav-gogia merged commit 4bbb647 into tenable:master Jun 17, 2021
@gaurav-gogia gaurav-gogia deleted the bugfix/k8s_id_field branch June 17, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nasir-rabbani nasir-rabbani nasir-rabbani left review comments

@shreyas-phansalkar-189 shreyas-phansalkar-189 shreyas-phansalkar-189 approved these changes

@harkirat22 harkirat22 Awaiting requested review from harkirat22

Assignees

@gaurav-gogia gaurav-gogia

Labels
policy Issue concerning policy maintainers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaurav-gogia @nasir-rabbani @shreyas-phansalkar-189