Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CGO independent package for sqlite #906

Merged
merged 4 commits into from
Jul 1, 2021

Conversation

kanchwala-yusuf
Copy link
Contributor

@kanchwala-yusuf kanchwala-yusuf commented Jul 1, 2021

fixes #835 , #864, #884

@kanchwala-yusuf kanchwala-yusuf marked this pull request as draft July 1, 2021 07:09
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #906 (4ba3060) into master (9e962b9) will decrease coverage by 0.05%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #906      +/-   ##
==========================================
- Coverage   79.08%   79.03%   -0.06%     
==========================================
  Files         211      211              
  Lines        5117     5119       +2     
==========================================
- Hits         4047     4046       -1     
- Misses        826      828       +2     
- Partials      244      245       +1     
Impacted Files Coverage Δ
pkg/k8s/dblogs/webhook-scan-logger.go 75.89% <33.33%> (-2.29%) ⬇️

@kanchwala-yusuf kanchwala-yusuf marked this pull request as ready for review July 1, 2021 07:54
@sonarcloud
Copy link

sonarcloud bot commented Jul 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kanchwala-yusuf kanchwala-yusuf linked an issue Jul 1, 2021 that may be closed by this pull request
Copy link
Contributor

@devang-gaur devang-gaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the release workflow on my fork, worked alright. https://github.com/dev-gaur/terrascan/releases/tag/v9.4

@devang-gaur devang-gaur merged commit bedfaa1 into tenable:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor to Disable CGO Issues running terrascan in azure pipelines
2 participants