Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload mutex activates even if you have nothing to reload #4178

Closed
rebelvg opened this issue Jul 28, 2016 · 8 comments
Closed

Reload mutex activates even if you have nothing to reload #4178

rebelvg opened this issue Jul 28, 2016 · 8 comments
Assignees
Milestone

Comments

@rebelvg
Copy link
Contributor

rebelvg commented Jul 28, 2016

Arma 3 Version: 1.62 (stable)
CBA Version: 3.0.0 (stable)
ACE3 Version: 3.6.2 (76b0491)

Mods:

  • @CBA_A3
  • @ace

Description:

  • I understand that reload mutex just detects a key press and not an actual reload. So if you have no mags for your main weapon and press R mutex will activate. Not a major issue but I guess you can add a check if player has mags for his weapon in the inventory and only then activate switch isReloading to true.

Steps to reproduce:

  • Press R when you have no mags for your current weapon (reload doesn't happen).
  • Try to throw a grenade via advanced throwing module.

Where did the issue occur?

  • Dedicated / Self-Hosted Multiplayer / Singleplayer / Editor (Singleplayer) / Editor (Multiplayer) / Virtual Arsenal

Placed Modules:

  • None.

RPT log file:

  • N/A.
@jonpas
Copy link
Member

jonpas commented Jul 28, 2016

Something like that should work.
!(((magazines player) arrayIntersect (getArray (configFile >> "CfgWeapons" >> "magazines"))) isEqualTo [])

@commy2
Copy link
Contributor

commy2 commented Jul 28, 2016

Sounds like unnecessary overhead to me

@jonpas
Copy link
Member

jonpas commented Jul 28, 2016

The code I posted should be fairly quick, I'd say this is a needed fix.

@commy2
Copy link
Contributor

commy2 commented Jul 28, 2016

arrayIntersect is case sensitive. The BI vanilla configs have magazine capitalization all over the place. Needs apply {toLower _x} on both sides

@jonpas
Copy link
Member

jonpas commented Jul 28, 2016

Even that should be fairly fast. It will also be executed only if reload key is pressed and weapon is in hand.

@commy2 commy2 added this to the Backlog milestone Sep 25, 2016
@commy2 commy2 self-assigned this Sep 25, 2016
@acemod-bot
Copy link
Member

Hello @acemod/maintainers. This ticket has been open for over 160 days without any activity.

@commy2
Copy link
Contributor

commy2 commented Mar 4, 2017

vote for close

@commy2
Copy link
Contributor

commy2 commented Aug 6, 2021

finally!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants