Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"make" (for production) should not run eslint #5186

Closed
driusan opened this issue Aug 28, 2019 · 2 comments
Closed

"make" (for production) should not run eslint #5186

driusan opened this issue Aug 28, 2019 · 2 comments
Labels
Beginner Friendly PR or Issue appears to be easy for someone to use to familiarize themselves with LORIS Cleanup PR or issue introducing/requiring at least one clean-up operation Stale PR has had no activity. Should be triaged for review or possibly closed as low priority.

Comments

@driusan
Copy link
Collaborator

driusan commented Aug 28, 2019

eslint is a development tool for javascript. It should not be required when running "make" on a production server for the release.
@johnsaigle johnsaigle added Beginner Friendly PR or Issue appears to be easy for someone to use to familiarize themselves with LORIS Cleanup PR or issue introducing/requiring at least one clean-up operation labels Sep 9, 2019
@stale
Copy link

stale bot commented Jan 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale PR has had no activity. Should be triaged for review or possibly closed as low priority. label Jan 7, 2020
@laemtl
Copy link
Contributor

laemtl commented Dec 20, 2022 •
edited
Loading

Fixed by #8229

@driusan driusan mentioned this issue Feb 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Beginner Friendly PR or Issue appears to be easy for someone to use to familiarize themselves with LORIS Cleanup PR or issue introducing/requiring at least one clean-up operation Stale PR has had no activity. Should be triaged for review or possibly closed as low priority.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@driusan @johnsaigle @laemtl