Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loris instrument help not working #7499

Closed
jstirling91 opened this issue Jun 29, 2021 · 1 comment · Fixed by #6907
Closed

Loris instrument help not working #7499

jstirling91 opened this issue Jun 29, 2021 · 1 comment · Fixed by #6907
Labels
24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)

Comments

@jstirling91
Copy link
Contributor

Describe the bug
When viewing an instrument, which has a help section in the help editor, upon clicking the help icon the following message is shown instead of the help text identified in the help editor.

No help available for instruments (/var/www/loris/modules/instruments/help/instruments.md)

To Reproduce
Steps to reproduce the behavior (attach screenshots if applicable):

  1. Ensure a help section has been added for a specific instrument.
  2. Navigate to the instrument.
  3. Click the help icon in the menu bar.

What did you expect to happen?
The help description for thqt instrument to show.

Browser Environment (please complete the following information):

  • chrome

Server Environment (if known):
Note: We only support the most recent release of LORIS.

  • LORIS Version: 23.0.3
  • Linux distribution and Version: [Ubuntu 16.04
  • MySQL/MariaDB Version: MariaDB 10.3

Additional context
In 21.0 when calling for the help description the instrument name was passed as the test_name. In 23.0 instruments is passed for all instrument help. The actual instrument is no longer passed.
@jstirling91 jstirling91 added the Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) label Jun 29, 2021
@jstirling91 jstirling91 added this to the 23.0.5 milestone Jun 29, 2021
@ridz1208 ridz1208 linked a pull request Jun 29, 2021 that will close this issue
[Raisinbread] Fixing help_editor module to display RB instrument instructions #6907
Merged
@ridz1208 ridz1208 removed this from the 23.0.5 milestone Aug 16, 2021
@racostas racostas mentioned this issue Dec 7, 2021
Closed
14 tasks
@racostas racostas added the 24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 label Dec 7, 2021
@zaliqarosli
Copy link
Contributor

this was fixed by #6907

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Raisinbread] Fixing help_editor module to display RB instrument instructions AlexandraLivadas/Loris
4 participants
@jstirling91 @ridz1208 @zaliqarosli @racostas