Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[instruments] Failed test item 9. Check that access restriction in config.xml works. #8708

Closed
zaliqarosli opened this issue May 16, 2023 · 3 comments
Assignees
Labels
25.0.0 - Bugs Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Documentation PR or issue introducing/requiring modifications to the code documentation (test plans, wikis, docs)

Comments

@zaliqarosli
Copy link
Contributor

Describe the bug
Instrument still accessible if user did not have permission configured in config.xml

To Reproduce
Steps to reproduce the behavior (attach screenshots if applicable):

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

What did you expect to happen?
A clear and concise description of what you expected to happen.

Browser Environment (please complete the following information):

  • OS: [e.g. Plan9, HURD, Oberon, etc]
  • Browser [e.g. chrome, firefox] (note that only these two browsers are supported)
  • Version [e.g. 22]

Server Environment (if known):
Note: We only support the most recent release of LORIS.

  • LORIS Version: [e.g. 22.0.0]
  • Linux distribution and Version: [e.g. Ubuntu 16.04, CentOS 7]
  • MySQL/MariaDB Version: [e.g. MySQL 5.7, MariaDB 10.3]

Additional context
Add any other context about the problem here.

@zaliqarosli zaliqarosli added Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) 25.0.0 - Bugs labels May 16, 2023
@zaliqarosli zaliqarosli mentioned this issue May 16, 2023
14 tasks
@driusan
Copy link
Collaborator

driusan commented May 30, 2023

It's in the database now. Test plan needs updating after #8302

@driusan
Copy link
Collaborator

driusan commented May 30, 2023

@charliehenrib see above comment. Think this is just a test plan update.

@driusan driusan added the Documentation PR or issue introducing/requiring modifications to the code documentation (test plans, wikis, docs) label May 30, 2023
@regisoc
Copy link
Contributor

regisoc commented Jun 12, 2023

@driusan my understanding is this issue can be closed.
It is a resolved documentation issue (instrument permissions are now in db, instead of config.xml file, issue #8755, PR #8765).

@driusan driusan closed this as completed Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
25.0.0 - Bugs Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Documentation PR or issue introducing/requiring modifications to the code documentation (test plans, wikis, docs)
Projects
None yet
Development

No branches or pull requests

4 participants