Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test Vm 26] EEG Browser major testing blockers, prob minor issues #9160

Closed
1 of 3 tasks
christinerogers opened this issue Mar 22, 2024 · 5 comments
Closed
1 of 3 tasks
Assignees
Labels
26.0.0-bugs Issues that were raised during the release testing for 26.0.0 Blocking PR should be prioritized because it is blocking the progress of another task Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)

Comments

@christinerogers
Copy link
Contributor

christinerogers commented Mar 22, 2024

These might just be Test VM issue -- @jeffersoncasimir can you point @kongtiaowang to the patch that needs to be sourced maybe?
Can't test the rest of the module otherwise.

Screen Shot 2024-03-22 at 5 28 00 PM
  • no HED/score schemas available -- can't use Dataset Tag Manager
Screen Shot 2024-03-22 at 5 34 32 PM
  • broken HED logo image in the Dataset Tag Manager modal top-left
    (because it's on images.loris.ca? @jeffersoncasimir )
Screen Shot 2024-03-22 at 5 30 59 PM
@christinerogers christinerogers added Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Blocking PR should be prioritized because it is blocking the progress of another task 26.0.0-bugs Issues that were raised during the release testing for 26.0.0 labels Mar 22, 2024
@jeffersoncasimir
Copy link
Contributor

@christinerogers All 3 issues have now been addressed

@driusan
Copy link
Collaborator

driusan commented Mar 25, 2024

@jeffersoncasimir can this be closed then? Was it related to the VM or does it need code changes / PRs?

@christinerogers
Copy link
Contributor Author

Partly resolved by #9161
@jeffersoncasimir does #9159 need to be merged for this to be resolved in the release? (even tho it's fixed on the VM for now)

@jeffersoncasimir
Copy link
Contributor

@driusan Yes this can be closed.

@christinerogers Yes it needs to be merged. It's a configuration-dependent issue that happens to affect the test VM.

@christinerogers
Copy link
Contributor Author

christinerogers commented Mar 25, 2024

@driusan Yes this can be closed.

@christinerogers Yes it needs to be merged. It's a configuration-dependent issue that happens to affect the test VM.

great, please make sure 9159 is tagged Critical to release then if it's needed for the module to not break. @jeffersoncasimir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
26.0.0-bugs Issues that were raised during the release testing for 26.0.0 Blocking PR should be prioritized because it is blocking the progress of another task Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
Projects
None yet
Development

No branches or pull requests

4 participants