feat: add function to retrieve recently played games #134
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Yo! Briefly skimming, it looks like a huge yarn.lock update made it into the PR. I just pulled the latest and ran |
|
Looks like Prettier and possibly ESLint did not run. Can you do
|
There was a problem hiding this comment.
Good work. I have a few comments here, but they are mostly minor.
We will also need to update README.md, as well as the Docusaurus site. You can spin up the Docusaurus site by cding into the website directory, installing deps with yarn, and then executing yarn start.
The main structural change I believe that needs to happen in this PR is the creation of a src/graphql folder and the migration of the new stuff into there.
Co-authored-by: Wes Copeland <wlcopeland1@gmail.com>
Co-authored-by: Wes Copeland <wlcopeland1@gmail.com>
Co-authored-by: Wes Copeland <wlcopeland1@gmail.com>
docs: add docs for new recently played games funcs
|
Alrighty, I think I've addressed alot of whats mentioned here. I'm sure there's some other minor things I might have missed, or need tweaking, so LMK 😄 |
|
Looking good! I think the last thing we're missing is a small addition to README.md which will contain a direct URL to the new docs. I believe the URL will be: |
chore: refactor getRecentlyPlayedGames test doc: update readme with getRecentlyPlayedGames
|
Almost there! Addressed the newest comments 😄 |
|
@all-contributors please add @evanshortiss for code and documentation |
|
I've put up a pull request to add @evanshortiss! 🎉 |
|
🎉 This PR is included in version 2.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I had been relying on the trophy titles endpoint/functions to find my recently played games. I noticed this approach wasn't accurate since I don't always unlock a trophy when playing a given game.
This PR provides an alternative that appears to be based purely on activity. It uses a GraphQL endpoint that has persisted queries enabled, so it might be a little tedious to support if PSN makes changes to their GraphQL queries/schemas.
LMK what you think. I'm happy to make changes to keep the code more aligned with the existing style etc.