fix: bring quote props rule inline with prettier config #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like something that should be being handled by I've not had (not against this change - it seems like the right thing to do, but just curious to why we've not come across this before) |
|
Actually, this has to be being disabled by something currently, as we're clearly not quoting properties always (the file your editing has properties that eslint isn't flagging), so yeah, weird. This change is definitely what we want 😅 |
G-Rath
changed the title
G-Rath
approved these changes
Apr 29, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Apr 29, 2021
## [2.1.2](v2.1.1...v2.1.2) (2021-04-29) ### Bug Fixes * bring quote props rule inline with prettier config ([#101](#101)) ([98b448b](98b448b))
|
🎉 This PR is included in version 2.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
G-Rath
added a commit
that referenced
this pull request
Aug 6, 2024
This reverts #101 which was never actually needed - for the most part having it configured is harmless since it matches our prettier config which in theory all of our codebases use, but if we ever have one that has a different [quote props](https://prettier.io/docs/en/options.html#quote-props) setting (e.g. due to an inherited codebase) then you have to deal with this. Removing it's configuration just means one less place to stub your toe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to get prettier and eslint not conflicting over quote-props;
https://github.com/ackama/prettier-config-ackama/blob/master/.prettierrc.json
The prettierrc specifies
"quoteProps": "consistent"but the default eslint rule for quote-props is "always", which conflicts with the specification of the prettierrc. In order to match the suggested code style in prettierrc, we need to update the eslint to the matching config of 'consistent-as-needed'