-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard should have clear messaging indicating enabled vs. disabled state. #104
Comments
Doesn't disabling dashboard cut the server? So the client would not be able to indicate if it was disabled or if it simply wasn't connected? |
It doesn't cut the server. The server is serving OnBot Java, Blocks, and the Program and Manage page as well, so you can't just shut down the server. So the dash route still returns a page. What it does cut is the websocket connection, so you don't get the ping updates and such. However, if you aren't intimately familiar with how the dashboard works it looks just like it's broken and you don't know why. I didn't look into it much further than that, but it does appear that server itself knows that the dashboard is disabled, and hence presumably the route, that is still serving the page, could send an indication that the dashboard is disabled with a little explanatory text explaining how to turn it back on. |
My apologies. I mis-spoke confusing server and socket. |
I don't think it needs to be dynamic necessarily. The natural thing to do is to refresh the page if things look wonky, at which point the disabled message could be displayed. Although I do believe that the client should be able to know when the websocket is down and display a message appropriately. Although I will admit to not having done any React development. |
Cutting the websocket connection doesn't give much additional security. Cheating is still only a few changes away for determined teams. I'm leaning toward keeping the connection alive and displaying a proper help message when the client is disabled. |
This is exactly my question: how to turn it back on if I disabled it? I tried disconnecting but still disabled. |
Try running the op mode called "Enable/Disable Dashboard" |
Also this is fixed in master. |
When the dashboard is disabled, it looks like it simply hasn't been initialized. The opmode list is empty, there are no configuration items etc.
It would be useful to have either an overlay, or something in the blue banner indicating state, particularly when disabled so a user doesn't perhaps wonder why the dashboard appears broken.
The text was updated successfully, but these errors were encountered: