Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

If 'name' field of request ends in dot, you get a 500 #48

Open
cjellick opened this issue Sep 14, 2022 · 0 comments
Open

If 'name' field of request ends in dot, you get a 500 #48

cjellick opened this issue Sep 14, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@cjellick
Copy link
Member

On posting new records, if you have an entry that looks like this:

{
    "name": "test.",
    "type": "TXT",
    "values": ["xyz"]
}

We will construct the FQDN to send to route53 as test..foo.on-acorn.io. That double dot will cause route53 to blow up with:

    "msg": "failed to upsert route53 record _acme-challenge..zpab5z.dev.on-acorn.io with error InvalidChangeBatch: [FATAL problem: DomainLabelEmpty (Domain label is empty) encountered with '_acme-challenge..zpab5z.dev.on-acorn.io']\n\tstatus code: 400, request id: a6f2a8e6-c024-4010-8a90-24a75be269e4"

We should handle that more gracefully through validation.

@cjellick cjellick added the bug Something isn't working label Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant