Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rule: ARIA state or property has valid value #365

Closed
jeeyyy opened this issue Dec 6, 2018 · 8 comments
Closed

Update Rule: ARIA state or property has valid value #365

jeeyyy opened this issue Dec 6, 2018 · 8 comments
Assignees
Labels
Discussion Rule Update Use this label for an existing rule that is being updated Rule Use this label for a new rule that does not exist already

Comments

@jeeyyy
Copy link
Collaborator

jeeyyy commented Dec 6, 2018

Rule: https://auto-wcag.github.io/auto-wcag/rules/SC4-1-2-aria-state-or-property-has-valid-value.html

In the below scenario, the rule fails SC 4.1.2, but it should fail SC 1.3.1 instead, because 4.1.2 does not tackle relationships between owned and context elements.

Suggestions:

Thoughts welcome.

image

@annethyme annethyme added Rule Update Use this label for an existing rule that is being updated Rule Use this label for a new rule that does not exist already labels Jan 7, 2019
@jeeyyy
Copy link
Collaborator Author

jeeyyy commented Jan 10, 2019

State/ Property SC Description
aria-atomic 4.1.3 Indicates whether assistive technologies will present all, or only parts of, the changed region based on the change notifications defined by the aria-relevant attribute.
aria-autocomplete 1.3.5 Indicates whether inputting text could trigger display of one or more predictions of the user's intended value for an input and specifies how predictions would be presented if they are made.
aria-busy 1.3.1 Indicates an element is being modified and that assistive technologies MAY want to wait until the modifications are complete before exposing them to the user.
aria-checked 1.3.1 Indicates the current "checked" state of checkboxes, radio buttons, and other widgets. See related aria-pressed and aria-selected.
aria-colcount Defines the total number of columns in a table, grid, or treegrid. See related aria-colindex.
aria-colindex Defines an element's column index or position with respect to the total number of columns within a table, grid, or treegrid. See related aria-colcount and aria-colspan.
aria-colspan Defines the number of columns spanned by a cell or gridcell within a table, grid, or treegrid. See related aria-colindex and aria-rowspan.
aria-controls 1.3.1 Identifies the element (or elements) whose contents or presence are controlled by the current element. See related aria-owns.
aria-current 1.3.1 Indicates the element that represents the current item within a container or set of related elements.
aria-describedby 1.3.1 Identifies the element (or elements) that describes the object. See related aria-labelledby.
aria-details 1.3.1 Identifies the element that provides a detailed, extended description for the object. See related aria-describedby.
aria-disabled 1.3.1 Indicates that the element is perceivable but disabled, so it is not editable or otherwise operable. See related aria-hidden and aria-readonly.
aria-dropeffect ???? [Deprecated in ARIA 1.1] Indicates what functions can be performed when a dragged object is released on the drop target.
aria-errormessage 1.3.1 Identifies the element that provides an error message for the object. See related aria-invalid and aria-describedby.
aria-expanded 1.3.1 Indicates whether the element, or another grouping element it controls, is currently expanded or collapsed.
aria-flowto 1.3.2 Identifies the next element (or elements) in an alternate reading order of content which, at the user's discretion, allows assistive technology to override the general default of reading in document source order.
aria-grabbed ???? [Deprecated in ARIA 1.1] Indicates an element's "grabbed" state in a drag-and-drop operation.
aria-haspopup 1.3.1 Indicates the availability and type of interactive popup element, such as menu or dialog, that can be triggered by an element.
aria-hidden 1.1. Indicates whether the element is exposed to an accessibility API. See related aria-disabled.
aria-invalid 3.3.1 Indicates the entered value does not conform to the format expected by the application. See related aria-errormessage.
aria-keyshortcuts NONE Indicates keyboard shortcuts that an author has implemented to activate or give focus to an element.
aria-label 4.1.2 Defines a string value that labels the current element. See related aria-labelledby.
aria-labelledby 4.1.2 Identifies the element (or elements) that labels the current element. See related aria-describedby.
aria-level 1.3.1 Defines the hierarchical level of an element within a structure.
aria-live 4.1.3 Indicates that an element will be updated, and describes the types of updates the user agents, assistive technologies, and user can expect from the live region.
aria-modal NONE Indicates whether an element is modal when displayed.
aria-multiline NONE Indicates whether a text box accepts multiple lines of input or only a single line.
aria-multiselectable NONE Indicates that the user may select more than one item from the current selectable descendants.
aria-orientation NONE Indicates whether the element's orientation is horizontal, vertical, or unknown/ambiguous.
aria-owns 1.3.1 Identifies an element (or elements) in order to define a visual, functional, or contextual parent/child relationship between DOM elements where the DOM hierarchy cannot be used to represent the relationship. See related aria-controls.
aria-placeholder NONE Defines a short hint (a word or short phrase) intended to aid the user with data entry when the control has no value. A hint could be a sample value or a brief description of the expected format.
aria-posinset 1.3.1 Defines an element's number or position in the current set of listitems or treeitems. Not required if all elements in the set are present in the DOM. See related aria-setsize.
aria-pressed 4.1.2 Indicates the current "pressed" state of toggle buttons. See related aria-checked and aria-selected.
aria-readonly NONE Indicates that the element is not editable, but is otherwise operable. See related aria-disabled.
aria-relevant 4.1.3 Indicates what notifications the user agent will trigger when the accessibility tree within a live region is modified. See related aria-atomic.
aria-required 3.3.2 Indicates that user input is required on the element before a form may be submitted.
aria-roledescription NONE Defines a human-readable, author-localized description for the role of an element.
aria-rowcount 1.3.1 Defines the total number of rows in a table, grid, or treegrid. See related aria-rowindex.
aria-rowindex 1.3.1 Defines an element's row index or position with respect to the total number of rows within a table, grid, or treegrid. See related aria-rowcount and aria-rowspan.
aria-rowspan 1.3.1 Defines the number of rows spanned by a cell or gridcell within a table, grid, or treegrid. See related aria-rowindex and aria-colspan.
aria-selected 4.1.2 Indicates the current "selected" state of various widgets. See related aria-checked and aria-pressed.
aria-setsize 1.3.1 Defines the number of items in the current set of listitems or treeitems. Not required if all elements in the set are present in the DOM. See related aria-posinset.
aria-sort 4.1.2 Indicates if items in a table or grid are sorted in ascending or descending order.
aria-valuemax 1.3.1 Defines the maximum allowed value for a range widget.
aria-valuemin 1.3.1 Defines the minimum allowed value for a range widget.
aria-valuenow 4.1.2 Defines the current value for a range widget. See related aria-valuetext.
aria-valuetext 4.1.2 Defines the human readable text alternative of aria-valuenow for a range widget.

@jeeyyy
Copy link
Collaborator Author

jeeyyy commented Jan 22, 2019

@WilcoFiers - see above for tabulation of SC vs states and properties.

@annethyme
Copy link
Collaborator

I am assigning this rule to myself since I am the owner of this rule inside the WAI-Tools project. It has a deadline of March 31.

@annethyme
Copy link
Collaborator

Related to #376

@WilcoFiers
Copy link
Member

@annethyme Here are 3 proposals that I would be okay with, please let me know which one's you think could be adopted in Alpha.

  1. Add a mapping to ARIA 1.1, leaving 4.1.2 in there, and adding an assumption about all elements with aria-* or role being user interface components.
  2. Duplicate the rule specifically for mapping to ARIA, so we have one rule that maps to ARIA without assumptions, and a second that maps to WCAG 4.1.2 with assumptions
  3. Split the rule up over two or more rules (TBD), with the combined scope similar to the scope of the existing rule, and those rules mapping to at least one WCAG success criterion.

@annethyme
Copy link
Collaborator

No matter what course this take, we suggest editing the Applicability to handle other comments that have come in. I gave it a shot in #464.

@annethyme
Copy link
Collaborator

Three different draft rules that tried to take on the challenge of creating a rule for (some of) this where we could all agree on the accessibility requirement mapping: #441, #454, #464

@jeeyyy
Copy link
Collaborator Author

jeeyyy commented Jul 3, 2019

@jeeyyy jeeyyy closed this as completed Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Rule Update Use this label for an existing rule that is being updated Rule Use this label for a new rule that does not exist already
Projects
None yet
Development

No branches or pull requests

4 participants