Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separation of engine ops and validation of params #298

Open
pferrel opened this issue Apr 9, 2021 · 2 comments
Open

separation of engine ops and validation of params #298

pferrel opened this issue Apr 9, 2021 · 2 comments
Assignees
Milestone

Comments

@pferrel
Copy link
Collaborator

pferrel commented Apr 9, 2021

we should add better synchronous validation when engine ops happen now that they are async.

@pferrel
Copy link
Collaborator Author

pferrel commented Apr 9, 2021

With etcd we have moved the validation of engine params into the deferred processing of the engine-add notification. In the past validation was synchronous with the engine-add command and there was no notification. The effect of this separation of validation means virtually no validation happens synchronous with the angine-add REST call. We can refactor this is to support more validation.

engine add, and update are affected

@pferrel pferrel added this to the future milestone Apr 9, 2021
@pferrel pferrel self-assigned this Apr 9, 2021
@pferrel
Copy link
Collaborator Author

pferrel commented Apr 9, 2021

only applies to Harness 1.0+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant